systemd-189: missing headers?

[Allin Cottrell]

The systemd-189 release doesn't compile out of the box on my
system (gcc 4.7.1, glibc-2.16.0, Linux 3.5.2). It seems that
some required headers are not being included in several source
files under src/journal/. Specifically,

* journald-kmsg.c, journald-console.c and journald-gperf.c all
need <sys/socket.h> for struct ucred.

* journald-syslog.c, journald-stream.c and journald-native.c
all need <stddef.h> for offsetof().

--
Allin Cottrell
Department of Economics
Wake Forest University, NC
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Kay Sievers]

The systemd-189 release doesn't compile out of the box on my system (gcc
4.7.1, glibc-2.16.0, Linux 3.5.2). It seems that some required headers are
not being included in several source files under src/journal/. Specifically,
* journald-kmsg.c, journald-console.c and journald-gperf.c all need
<sys/socket.h> for struct ucred.
* journald-syslog.c, journald-stream.c and journald-native.c
all need <stddef.h> for offsetof().

Mind just sending a patch that makes it work for you?

We do not see that issue on our systems.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Allin Cottrell]

Post by Kay Sievers

The systemd-189 release doesn't compile out of the box on my system (gcc
4.7.1, glibc-2.16.0, Linux 3.5.2). It seems that some required headers are
not being included in several source files under src/journal/. Specifically,
* journald-kmsg.c, journald-console.c and journald-gperf.c all need
<sys/socket.h> for struct ucred.
* journald-syslog.c, journald-stream.c and journald-native.c
all need <stddef.h> for offsetof().

Mind just sending a patch that makes it work for you?

No problem; patch now attached.

--
Allin Cottrell
Department of Economics
Wake Forest University, NC

[Kay Sievers]

Post by Allin Cottrell

Post by Kay Sievers

The systemd-189 release doesn't compile out of the box on my system (gcc
4.7.1, glibc-2.16.0, Linux 3.5.2). It seems that some required headers are
not being included in several source files under src/journal/. Specifically,
* journald-kmsg.c, journald-console.c and journald-gperf.c all need
<sys/socket.h> for struct ucred.
* journald-syslog.c, journald-stream.c and journald-native.c
all need <stddef.h> for offsetof().

Mind just sending a patch that makes it work for you?

No problem; patch now attached.

Applied.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html