Discussion:
[PATCH] Always populate EXTRA_DIST
Bryan Kadzban
2012-06-08 06:03:51 UTC
Permalink
"make dist" can build a different tarball depending on the flags passed
to ./configure and the (optional) dependencies found on the system.
Move all append-to-EXTRA_DIST operations out of automake conditionals to
fix this.

Introduce a polkitpolicy_files so that the policy files built still
correctly depend on the automake conditionals, but the .in files that
get distributed do not.

Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
Bryan Kadzban
2012-06-08 06:24:16 UTC
Permalink
Post by Bryan Kadzban
"make dist" can build a different tarball depending on the flags passed
to ./configure and the (optional) dependencies found on the system.
Move all append-to-EXTRA_DIST operations out of automake conditionals to
fix this.
Introduce a polkitpolicy_files so that the policy files built still
correctly depend on the automake conditionals, but the .in files that
get distributed do not.
Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
Arg, always compile-check. Tested, this time.

v2, fixing warnings about polkitpolicy_files not being defined.
Lennart Poettering
2012-07-10 00:06:29 UTC
Permalink
Post by Bryan Kadzban
Post by Bryan Kadzban
"make dist" can build a different tarball depending on the flags passed
to ./configure and the (optional) dependencies found on the system.
Move all append-to-EXTRA_DIST operations out of automake conditionals to
fix this.
Introduce a polkitpolicy_files so that the policy files built still
correctly depend on the automake conditionals, but the .in files that
get distributed do not.
Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
Arg, always compile-check. Tested, this time.
v2, fixing warnings about polkitpolicy_files not being defined.
Looks good, but could you rebase this to current master? Will apply then.

Thanks!

Lennart
--
Lennart Poettering - Red Hat, Inc.
Bryan Kadzban
2012-07-28 02:43:38 UTC
Permalink
Post by Lennart Poettering
Post by Bryan Kadzban
Post by Bryan Kadzban
"make dist" can build a different tarball depending on the flags passed
to ./configure and the (optional) dependencies found on the system.
Move all append-to-EXTRA_DIST operations out of automake conditionals to
fix this.
Introduce a polkitpolicy_files so that the policy files built still
correctly depend on the automake conditionals, but the .in files that
get distributed do not.
Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
Arg, always compile-check. Tested, this time.
v2, fixing warnings about polkitpolicy_files not being defined.
Looks good, but could you rebase this to current master? Will apply then.
v3, rebased. (Finally got time to do this.)
Zbigniew Jędrzejewski-Szmek
2012-07-28 21:14:21 UTC
Permalink
Post by Bryan Kadzban
Post by Lennart Poettering
Post by Bryan Kadzban
Post by Bryan Kadzban
"make dist" can build a different tarball depending on the flags passed
to ./configure and the (optional) dependencies found on the system.
Move all append-to-EXTRA_DIST operations out of automake conditionals to
fix this.
Introduce a polkitpolicy_files so that the policy files built still
correctly depend on the automake conditionals, but the .in files that
get distributed do not.
Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
Arg, always compile-check. Tested, this time.
v2, fixing warnings about polkitpolicy_files not being defined.
Looks good, but could you rebase this to current master? Will apply then.
v3, rebased. (Finally got time to do this.)
Commited.

Zbyszek

Loading...